Improve one line scope #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pangloss#293 this will detect the start and end parentheses,allowing statements with parentheses to come after the condition parens.This regex can detect with up to 4 levels of nesting.
Collaborator
Author
|
A random example were you can see the improvements |
Collaborator
|
I haven't had a chance to test this, but I assume you've been testing it yourself? I am fine to merge it in if no other maintainers object. |
Collaborator
Author
|
Yes, i haven't seen any issues either with performance or any bugs, if none of the other maintainers have any suggestions for changes to it I think it can atlas make it into develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#293
this will detect the start and end parentheses after 'if,for,while',allowing statements with parentheses to come after the condition parens.This regex can detect with up to 4 levels of nesting.